Compile fail OpenEmbedded Dunfell

[barryk]

Hi guys,
OpenEmbedded/Yocto (OE) is a cross-compiler, a build system that can create an entire Linux distribution. My fork of the "Pyro" release of OE, named oe-qky-src, a few years ago, was used to compile all the packages for the Pyro-series of EasyOS (my derivative of Puppy Linux).

Up until yesterday, I have been using bacon 3.7.2.

I decided it is time to recompile all of my packages in the latest release of OE, which is named "Dunfell". It has gone remarkably well, some package failures of course, that I have to try and fix. gcc is now 9.3.0 and glibc is 2.31. Also, python3 only, no python2.

I have bumped the bacon package to 4.1. That compiled OK.

My "pup-tools" package has utilities for Puppy Linux and derivatives, some of those written in bacon. The latest OE has compiled some of them, but has failed at compiling popup.bac.

Testing in my host system, EasyOS built from Debian 10 Buster DEBs, gcc 8.3.0, glibc 2.28, no problem. Mimic-ing how I do it in OE, and with bacon 4.1:

# ./bacon.sh  -y -n -p -d temp1 popup.bac
Converting 'popup.bac'... 173
Warning: duplicate symbol 'gtk_window_move' at line 173 in file 'popup.bac'!
Converting 'popup.bac'... done, 3606 lines were processed in 82 seconds.
Warning: no CLOSE for the OPEN handle 'thisdescr' at line 625 in file 'popup.bac'!
Warning: no CLOSE for the OPEN handle 'thisdescr' at line 622 in file 'popup.bac'!
WARNING: 'indent' not found on this system!
Generated source code cannot be beautified.
# cd temp1
# cc -fPIC -c popup.bac.c
# cc -o popup popup.bac.o -L. -lm  -ldl

Good. However, in OE it fails with this message:

| Converting 'popup.bac'... done, 3606 lines were processed in 81 seconds.
| Warning: no CLOSE for the OPEN handle 'thisdescr' at line 625 in file 'popup.bac'!
| Warning: no CLOSE for the OPEN handle 'thisdescr' at line 622 in file 'popup.bac'!
| WARNING: 'indent' not found on this system!
| Generated source code cannot be beautified.
| In file included from /mnt/sda1/nvme/oe/oe-quirky/build-amd64/tmp/work/core2-64-poky-linux/pup-tools/20200212-r0/recipe-sysroot/usr/include/fcntl.h:329,
|                  from popup.bac.generic.h:22,
|                  from popup.bac.h:2,
|                  from popup.bac.c:2:
| In function 'open',
|     inlined from 'main' at popup.bac:625:13:
| /mnt/sda1/nvme/oe/oe-quirky/build-amd64/tmp/work/core2-64-poky-linux/pup-tools/20200212-r0/recipe-sysroot/usr/include/bits/fcntl2.h:50:4: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
|    50 |    __open_missing_mode ();
|       |    ^~~~~~~~~~~~~~~~~~~~~~
| WARNING: /mnt/sda1/nvme/oe/oe-quirky/build-amd64/tmp/work/core2-64-poky-linux/pup-tools/20200212-r0/temp/run.do_compile.30464:1 exit 1 from 'x86_64-poky-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/mnt/sda1/nvme/oe/oe-quirky/build-amd64/tmp/work/core2-64-poky-linux/pup-tools/20200212-r0/recipe-sysroot -fPIC -c popup.bac.c -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/mnt/sda1/nvme/oe/oe-quirky/build-amd64/tmp/work/core2-64-poky-linux/pup-tools/20200212-r0=/usr/src/debug/pup-tools/20200212-r0 -fdebug-prefix-map=/mnt/sda1/nvme/oe/oe-quirky/build-amd64/tmp/work/core2-64-poky-linux/pup-tools/20200212-r0=/usr/src/debug/pup-tools/20200212-r0 -fdebug-prefix-map=/mnt/sda1/nvme/oe/oe-quirky/build-amd64/tmp/work/core2-64-poky-linux/pup-tools/20200212-r0/recipe-sysroot= -fdebug-prefix-map=/mnt/sda1/nvme/oe/oe-quirky/build-amd64/tmp/work/core2-64-poky-linux/pup-tools/20200212-r0/recipe-sysroot-native='
|

Here is the code in popup.bac:

IF name$!="" THEN
thisfile$=CONCAT$("/tmp/popup_",name$)
IF FILEEXISTS(thisfile$)==1 THEN
 OPTION DEVICE O_RDWR
 OPEN thisfile$ FOR DEVICE AS thisdescr
ELSE
 OPTION DEVICE O_RDWR|O_CREAT
 OPEN thisfile$ FOR DEVICE AS thisdescr [b]<<<LINE 625[/b]
ENDIF
TIMEOUT(500,wait_func)
END IF

Note, popup.bac uses hug.bac.

Does the error message and that line in the bacon code mean anything to you? I have inserted "<<<LINE 625" to show the offending line. Is it a bug?

Appreciate any feedback on this!

Regards,
Barry

[Pjot]

Hi barry,

The OPEN FOR DEVICE statements use the libc call "open". Apparently, GCC 9 is more picky about this function than GCC 8.

The "open" function in libc has two versions, one version using 2 arguments and one using 3 arguments. The latter only applies when using the O_CREAT flag. It then needs a "mode" flag (3rd argument) to specify the access rights for the newly created file.

So you ran into a new situation which does not occur in GCC 8 and earlier. And it would have happened with BaCon 3.7.2 as well.

The fix is easy though. Now the OPEN FOR DEVICE always will add the additional "mode" argument. When it is not needed then the "open" function simply will ignore it.

The latest version from fossil should solve this problem (cloning instructions are here).

Best regards
Peter

[barryk]

That's great, thanks very much, popup.bac now compiles.

Ha ha, another hurdle, now welcome1stboot.bac has failed. It also uses hug.bac, and I have version 0.109. This is the error message:

| In file included from welcome1stboot.bac:201,
|                  from welcome1stboot.bac.c:2:
| ./hug.bac: In function 'INIT':
| ./hug.bac:657:38: error: expected ';' before ']' token
| ./hug.bac:657:38: error: expected statement before ']' token
| ./hug.bac:657:39: error: expected expression before '[' token
| In file included from welcome1stboot.bac:201,
|                  from welcome1stboot.bac.c:2:
| ./hug.bac:663:2: error: expected ';' before '}' token

In hug.bac,line 657 is:

DECLARE hug_glfont[96][16] TYPE int

Is this a gcc9 thing again?

[barryk]

Actually, the problem might be in OE, rather than hug.bac.
For each package build, there is a recipe file, which specifies dependencies. OE creates a build environment for that package, with the core instrastructure plus the specified dependencies. Unlike a normal build environment, that will have everything previously compiled available, OE will have a limited build environment. For example, even though OE has compiled gtk+3, if I don't specify "gtk+3" as a dependency, it won't be in the package build environment. Thus, it is necessary to know all the deps that a package requires!

So, I am wondering about deps requirements for that "opengl".

Though, interesting that popup.bac compiled ok.

...but, welcome1stboot.bac did compile with a previous version of OE (and older gcc), so I don't think it is a deps problem.

[barryk]

Have tried in the host system, with gcc8, same failure:

# ./bacon.sh  -y -n -p -d temp1 welcome1stboot.bac
Converting 'welcome1stboot.bac'... done, 3166 lines were processed in 29 seconds.
WARNING: 'indent' not found on this system!
Generated source code cannot be beautified.
# cd temp1
# cc -fPIC -c welcome1stboot.bac.c
In file included from welcome1stboot.bac:201,
                from welcome1stboot.bac.c:2:
./hug.bac: In function ‘INIT’:
./hug.bac:657:38: error: expected ‘;’ before ‘]’ token
./hug.bac:657:38: error: expected statement before ‘]’ token
./hug.bac:657:39: error: expected expression before ‘[’ token
In file included from welcome1stboot.bac:201,
                from welcome1stboot.bac.c:2:
./hug.bac:663:2: error: expected ‘;’ before ‘}’ token
#

[barryk]

Just in case you need it, here is welcome1stboot.bac, attached:

Attachments:

welcome1stboot.bac.gz (3.49 KB)

[bigbass]

Hello barryk

hope all is well with you

your firstboot code compiles for me cleanly using RPI3
debian 10 buster using HUG www.basic-converter.org/hug.bac

howerver I get a run time error
Runtime error: statement 'IMPORT' at line 23 in 'welcome1stboot.bac': Could not open library.

which is easily fixed on my box by addig a .0 to the lib

IMPORT "gtk_widget_set_tooltip_text(long,char*)" FROM "libgtk-x11-2.0.so.0" TYPE void



I hope it could be useful for you some feedback from the RPI3


gcc --version
gcc (Raspbian 8.3.0-6+rpi1) 8.3.0


bacon -v
BaCon version 4.1 on Linux armv7l - (c) Peter van Eerten - MIT License.


you get a "warning" for indent a depedency for bacon
sudo apt-get install indent


Joe

[Pjot]

Hi barry,

The program compiles fine using the 'bacon' binary version. However, you're using the Shell version in the current beta.

In fact, you stumbled into a beta issue which would have revealed itself during regression testing also. The internal registration for array dimenions, used by the new UBOUND function, did have a flaw in the Shell version of BaCon.

It is fixed in the new beta, if you fetch it from fossil your program should compile fine.

For your information, I am planning to release BaCon 4.1.1 at October 1st.

Best regards
Peter

[barryk]

Peter, Joe,
Thanks for the fixes!

Hey, I'm glad that libbacon is gone!

Looking forward to 4.1.1.