OPEN FOR DIRECTORY

[alexfish]

HI Peter

I am having a problem with open directory ,as in nested like openstreetmaps

the bugs

Dir : /home/pi/bacon-osm-maps/8/./
Dir : /home/pi/bacon-osm-maps/8/81.png/
Runtime error: statement 'OPEN FOR DIRECTORY' at line 33 in '/home/pi/Downloads/seamap_converter.bac': Error opening file: No such file or directory

/home/pi/bacon-osm-maps/12/
Dir : /home/pi/bacon-osm-maps/12/./
Dir : /home/pi/bacon-osm-maps/12/1210.png
Runtime error: statement 'OPEN FOR DIRECTORY' at line 33 in '/home/pi/Downloads/seamap_converter.bac': Error opening file: No such file or directory


if asking does if happen in all directories ,no at present 8 an 12 zoom levels
example zoom 9
OPEN Dir : /home/pi/bacon-osm-maps/9/. gets skip as does the ..

only thing of note = 12/./ and that 1210.png is in the next directory /12/257/1210.png , note 12 & 1210.png
and zoom 8 would be /8/257/81.png , note the 8 & 81.png

if happen at the start of the read
and have the '.' and '..' notation

for other readers , to see this
do a ls -a



This is the program

'=================================================================================
' File seamap_converter.bac
OPTION PARSE FALSE

'===========================================
PRAGMA LDFLAGS `pkg-config   --libs gdk-pixbuf-2.0`
PRAGMA OPTIONS `pkg-config --cflags gdk-pixbuf-2.0`
'OSMDIR$ = HOME$ & "/bacon-osm-maps/" & STR$(ZOOM) & "/"
'===========================================
PRAGMA INCLUDE <gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf.h>
SUB UPDATE_SEAMAPS(OSMDIR$,ZOOM,REBUILD)
OSMDIR$ =OSMDIR$ & STR$(ZOOM) & "/"
LOCAL first
LOCAL myfile$
OPEN OSMDIR$ FOR DIRECTORY AS mydir
PRINT OSMDIR$
REPEAT
GETFILE myfile$ FROM mydir
getfile$= OSMDIR$ &  myfile$
OPEN getfile$ FOR DIRECTORY AS mydir2
REPEAT
GETFILE getfile$ FROM mydir2
' miss the zoom file if have used the original navigation app
IF getfile$ = "zoom" THEN

ELSE
myfile$ = OSMDIR$ & getfile$ & "/"
DIRS$ = getfile$ & "/"
FDIR$ = OSMDIR$ & getfile$ & "/"
DIRT$ = myfile$
PRINT "OPEN Dir : " ,myfile$

OPEN myfile$ FOR DIRECTORY AS mydir3
REPEAT

GETFILE myfile$ FROM mydir3

IF RIGHT$(DIRS$ & myfile$,4) = ".png" THEN
PRINT " Get png"
Searchdir$ = OSMDIR$ & DIRS$
INCR first
IF NOT(INSTR(myfile$,"S")) THEN
DESTINATION$ = FDIR$ & myfile$
SOURCER$ = FDIR$ & "S" & myfile$
IF NOT(FILEEXISTS(SOURCER$)) THEN
OSMTILE$ = "https://a.tile.openstreetmap.org/" & STR$(ZOOM) & "/" & DIRS$ & myfile$
TILE$ ="http://t1.openseamap.org/seamark/" & STR$(ZOOM) & "/" & DIRS$ & myfile$
PRINT TILE$
IF REBUILD THEN
Cmd$ =  "wget " & OSMTILE$ & " -O " & FDIR$ &  myfile$
SYSTEM(Cmd$)
END IF
Cmd$ =  "wget " & TILE$ & " -O " & FDIR$ & "S" & myfile$
SYSTEM(Cmd$)
LOCAL im1 , im2 TYPE GdkPixbuf*
im1 = gdk_pixbuf_new_from_file(DESTINATION$ , NULL)
im2 = gdk_pixbuf_new_from_file(SOURCER$, NULL)

w = gdk_pixbuf_get_width(im2)
h = gdk_pixbuf_get_height(im2)
IF w = -1 THEN

ELSE
gdk_pixbuf_composite(im2, im1, 0, 0, w, h, 0,0, 1,1, 0,255)
gdk_pixbuf_save (im1,DESTINATION$, "png", 0, NULL, NULL, NULL)

END IF
g_object_unref(im1)
g_object_unref(im2)
PRINT "========================================"

END IF
END IF
END IF

UNTIL ISFALSE(LEN(myfile$))
END IF

UNTIL ISFALSE(LEN(getfile$))

UNTIL ISFALSE(LEN(myfile$))

PRINT "converted : " , first
CLOSE DIRECTORY mydir
CLOSE DIRECTORY mydir3
CLOSE DIRECTORY mydir2

END SUB

'Dir : /home/pi/bacon-osm-maps/8/./
'/home/pi/bacon-osm-maps/8/
/*
Dir : /home/pi/bacon-osm-maps/8/./
Dir : /home/pi/bacon-osm-maps/8/81.png/
Runtime error: statement 'OPEN FOR DIRECTORY' at line 33 in '/home/pi/Downloads/seamap_converter.bac': Error opening file: No such file or directory
*/

' EXAMPLE ================================="

HOME$ = GETENVIRON$("HOME")
SEARCHDIR$ = HOME$ & "/bacon-osm-maps/"
'search dir , zoom ,rebuild TRUE/FALSE)
'FOR T = 13 TO 16
'UPDATE_SEAMAPS(SEARCHDIR$,9,0)
'NEXT

BR
Alex

[alexfish]

If do same sequence using EXEC$( "ls " & "path/to")

can get the bits without "./"

EXAMPLE
HOME$ = GETENVIRON$("HOME")
SEARCHDIR$ = HOME$ & "/bacon-osm-maps/"
GETDIR$ = CHOP$(EXEC$("ls " & SEARCHDIR$))
PRINT GETDIR$
PRINT "===================="
LOCAL dim , dim2 , dim3
SPLIT GETDIR$ BY NL$ TO array$ SIZE dim

FOR t = 0 TO dim -1
PRINT SEARCHDIR$ & array$[t] & "/"
GETNEXT$ = EXEC$( "ls " & SEARCHDIR$ & array$[t] & "/")
SPLIT GETNEXT$ BY NL$ TO array2$ SIZE dim2
FOR s = 0 TO dim2 -1
 PRINT SEARCHDIR$ & array$[t] & "/" & array2$[s] & "/"
 GETPNG$ = EXEC$("ls "  & SEARCHDIR$ & array$[t] & "/" & array2$[s] & "/")
 
 SPLIT GETPNG$ BY NL$ TO pngs$ SIZE dim3
  FOR p = 0 TO dim3 -1
  PRINT pngs$[p]
  NEXT
NEXT
PRINT "==================================================="
NEXT

part of the out
/home/pi/bacon-osm-maps/8/
/home/pi/bacon-osm-maps/8/123/
78.png
79.png
80.png
81.png
82.png
83.png
84.png

use ls -a loads of garbage
.
..
10
11
12
13
14
15
16
6
7
8
9
====================
/home/pi/bacon-osm-maps/./
/home/pi/bacon-osm-maps/././
.
..
10
11
12
13
14
15
16
6
7
8
9

/home/pi/bacon-osm-maps/./../
.
..
10
10362.png
10369.png
12
15
16
17




BR
Alex

[Pjot]

Hi Alex,

It looks like you are trying to open a file as a directory and that is not possible, even though the file is in that directory.

GETFILE myfile$ FROM mydir
getfile$= OSMDIR$ &  myfile$
OPEN getfile$ FOR DIRECTORY AS mydir2


If you open a directory, you have to be sure that it really is a directory and not a file.

But there is an other option which might be more easy. If you would like to (recursively) walk through a directory structure and list the available files in there, why not use the WALK$ function?

This part of your code:

OSMDIR$ = OSMDIR$ & STR$(ZOOM) & "/"
LOCAL first
LOCAL myfile$
OPEN OSMDIR$ FOR DIRECTORY AS mydir
PRINT OSMDIR$
REPEAT
GETFILE myfile$ FROM mydir
getfile$= OSMDIR$ &  myfile$
OPEN getfile$ FOR DIRECTORY AS mydir2
REPEAT
GETFILE getfile$ FROM mydir2


....would then become:

myfile$ = WALK$(OSMDIR$, 1, ".+", TRUE, NL$)


This is the meaning of the arguments:

1. This is the directory to start searching
2. This specifies the item, in this case '1' means "file"
3. This is the mask, here it means 'all files' but you could put ".*.png$" instead to only get files ending with 'png'
4. This is to indicate whether or not we want to look recursively in subdirectories
5. This specifies the delimiter in the returned result

After the WALK$ string function has put all your files into the "myfile$" variable, you can examine them one by one as follows:

FOR item$ IN myfile$ STEP NL$
<....your code....>
NEXT


This way, you do not need to use OPEN FOR DIRECTORY and the GETFILE statement anymore.

HTH
Peter

[alexfish]

Hi Peter

Thanks for the prompt reply

knew of the existence of WALK$ , never tried it

Very terse bit of code.


HOME$ = GETENVIRON$("HOME")
SEARCHDIR$ = HOME$ & "/bacon-osm-maps/"
OSMDIR$=SEARCHDIR$ & STR$(8) & "/"

myfile$ = WALK$(OSMDIR$, 1, ".+", TRUE, NL$)

FOR item$ IN myfile$ STEP NL$
PRINT item$
NEXT


result , part of the out
pi@raspberrypi:~/maps $ ./walk_osm
/home/pi/bacon-osm-maps/8/123/81.png
/home/pi/bacon-osm-maps/8/123/84.png
/home/pi/bacon-osm-maps/8/123/82.png
/home/pi/bacon-osm-maps/8/123/80.png
/home/pi/bacon-osm-maps/8/123/78.png
/home/pi/bacon-osm-maps/8/123/79.png
/home/pi/bacon-osm-maps/8/123/83.png
/home/pi/bacon-osm-maps/8/125/81.png
/home/pi/bacon-osm-maps/8/125/84.png
/home/pi/bacon-osm-maps/8/125/82.png
/home/pi/bacon-osm-maps/8/125/80.png
/home/pi/bacon-osm-maps/8/125/78.png
/home/pi/bacon-osm-maps/8/125/79.png
/home/pi/bacon-osm-maps/8/125/S81.png


Thanks again

BR
Alex